Sourcery refactored master branch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
+3
to
+16
|
|
||
| import requests | ||
| import sys | ||
|
|
||
| if __name__ == "__main__": | ||
| url = "https://jsonplaceholder.typicode.com/" | ||
| user = requests.get(url + "users/{}".format(sys.argv[1])).json() | ||
| todos = requests.get(url + "todos", params={"userId": sys.argv[1]}).json() | ||
| user = requests.get(f"{url}users/{sys.argv[1]}").json() | ||
| todos = requests.get(f"{url}todos", params={"userId": sys.argv[1]}).json() | ||
|
|
||
| completed = [t.get("title") for t in todos if t.get("completed") is True] | ||
| print("Employee {} is done with tasks({}/{}):".format( | ||
| user.get("name"), len(completed), len(todos))) | ||
| [print("\t {}".format(c)) for c in completed] | ||
| print( | ||
| f'Employee {user.get("name")} is done with tasks({len(completed)}/{len(todos)}):' | ||
| ) | ||
| [print(f"\t {c}") for c in completed] |
There was a problem hiding this comment.
Lines 8-14 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Replace call to format with f-string [×3] (
use-fstring-for-formatting)
| @@ -1,17 +1,18 @@ | |||
| #!/usr/bin/python3 | |||
| """Exports to-do list information for a given employee ID to CSV format.""" | |||
|
|
|||
There was a problem hiding this comment.
Lines 10-14 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Replace call to format with f-string [×2] (
use-fstring-for-formatting)
| @@ -1,17 +1,18 @@ | |||
| #!/usr/bin/python3 | |||
| """Exports to-do list information for a given employee ID to JSON format.""" | |||
|
|
|||
There was a problem hiding this comment.
Lines 10-14 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Replace call to format with f-string [×2] (
use-fstring-for-formatting)
Comment on lines
+3
to
+27
|
|
||
| import json | ||
| import requests | ||
|
|
||
| if __name__ == "__main__": | ||
| url = "https://jsonplaceholder.typicode.com/" | ||
| users = requests.get(url + "users").json() | ||
| users = requests.get(f"{url}users").json() | ||
|
|
||
| with open("todo_all_employees.json", "w") as jsonfile: | ||
| json.dump({ | ||
| u.get("id"): [{ | ||
| "task": t.get("title"), | ||
| "completed": t.get("completed"), | ||
| "username": u.get("username") | ||
| } for t in requests.get(url + "todos", | ||
| params={"userId": u.get("id")}).json()] | ||
| for u in users}, jsonfile) | ||
| json.dump( | ||
| { | ||
| u.get("id"): [ | ||
| { | ||
| "task": t.get("title"), | ||
| "completed": t.get("completed"), | ||
| "username": u.get("username"), | ||
| } | ||
| for t in requests.get( | ||
| f"{url}todos", params={"userId": u.get("id")} | ||
| ).json() | ||
| ] | ||
| for u in users | ||
| }, | ||
| jsonfile, | ||
| ) |
There was a problem hiding this comment.
Lines 8-18 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
| url = "https://www.reddit.com/r/{}/about.json".format(subreddit) | ||
| url = f"https://www.reddit.com/r/{subreddit}/about.json" |
There was a problem hiding this comment.
Function number_of_subscribers refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| url = "https://www.reddit.com/r/{}/hot/.json".format(subreddit) | ||
| url = f"https://www.reddit.com/r/{subreddit}/hot/.json" |
There was a problem hiding this comment.
Function top_ten refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| url = "https://www.reddit.com/r/{}/hot/.json".format(subreddit) | ||
| url = f"https://www.reddit.com/r/{subreddit}/hot/.json" |
There was a problem hiding this comment.
Function count_words refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting)
| url = "https://www.reddit.com/r/{}/hot/.json".format(subreddit) | ||
| url = f"https://www.reddit.com/r/{subreddit}/hot/.json" |
There was a problem hiding this comment.
Function recurse refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
+5
to
+14
|
|
||
| import sys | ||
|
|
||
| if __name__ == '__main__': | ||
| count_words = __import__('100-count').count_words | ||
| if len(sys.argv) < 3: | ||
| print("Usage: {} <subreddit> <list of keywords>".format(sys.argv[0])) | ||
| print("Ex: {} programming 'python java javascript'".format( | ||
| sys.argv[0])) | ||
| print(f"Usage: {sys.argv[0]} <subreddit> <list of keywords>") | ||
| print(f"Ex: {sys.argv[0]} programming 'python java javascript'") | ||
| else: | ||
| result = count_words(sys.argv[1], [x for x in sys.argv[2].split()]) | ||
| result = count_words(sys.argv[1], list(sys.argv[2].split())) |
There was a problem hiding this comment.
Lines 10-14 refactored with the following changes:
- Replace call to format with f-string [×2] (
use-fstring-for-formatting) - Replace identity comprehension with call to collection constructor (
identity-comprehension)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!